gh-142594: fix by property calls io.TextIOWrapper.detach #142706
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <[email protected]>
yihong0618
changed the title
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
cmaloney
reviewed
Dec 14, 2025
Misc/NEWS.d/next/Library/2025-12-14-18-30-48.gh-issue-142594.belDmD.rst
Outdated
Show resolved
Hide resolved
…elDmD.rst Co-authored-by: Cody Maloney <[email protected]>
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @yihong0618 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @yihong0618 and @encukou, I could not cleanly backport this to |
|
Sorry, @yihong0618 and @encukou, I could not cleanly backport this to |
Contributor
|
(Working on the backports; auto failed because of my refactor / move of |
|
GH-142755 is a backport of this pull request to the 3.14 branch. |
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Dec 15, 2025
…pythonGH-142706) (cherry picked from commit 1d3854a) Co-authored-by: yihong <[email protected]> Signed-off-by: yihong0618 <[email protected]>
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Dec 15, 2025
…pythonGH-142706) (cherry picked from commit 1d3854a) Co-authored-by: yihong <[email protected]> Signed-off-by: yihong0618 <[email protected]>
|
GH-142757 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
self->detachedcheckTextIOWrapper.close()via re-entrantclosedproperty that detachesbuffer#142594