Add test that IMAP4.enable() after SELECT raises an error#154186
Open
bontail wants to merge 1 commit into
Open
Add test that IMAP4.enable() after SELECT raises an error#154186bontail wants to merge 1 commit into
bontail wants to merge 1 commit into
Conversation
Resolve the long-standing XXX TODO in test_imaplib.py by covering the case where enable() is called from the SELECTED state: ENABLE is only valid in the AUTH state, so it must raise IMAP4.error.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve a long-standing
XXXTODO intest_imaplib.pyby covering thecase where
enable()is called from theSELECTEDstate.ENABLEis only valid in theAUTHstate (Commands['ENABLE'] == ('AUTH',)),so calling
enable()afterselect()must raiseimaplib.IMAP4.error. Thenew
test_enable_raises_error_after_selectauthenticates, selects a mailbox,then asserts that
enable('UTF8=ACCEPT')raises and does not setutf8_enabled.Test-only change; no behavior change.