Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTPS-based suggestion for cloning cpython #1287

Closed
wants to merge 1 commit into from

Conversation

davidlowryduda
Copy link

@davidlowryduda davidlowryduda commented Mar 8, 2024

Github removed support for password authentication through HTTPS on August 13, 2021. We shouldn't recommend that users use an HTTPS clone when an SSH-based [email protected]:<username>/cypthon.git connection is necessary.

This small change removes a comment that suggests that one could use HTTPS-based URLs.


📚 Documentation preview 📚: https://cpython-devguide--1287.org.readthedocs.build/

Github removed support for password authentication through HTTPS on
August 13, 2021. We shouldn't recommend that users use an HTTPS clone
when an SSH-based `[email protected]:<username>/cypthon.git` connection is
necessary.

This small change removes a comment that suggests that one *could* use
HTTPS-based URLs.
Copy link

cpython-cla-bot bot commented Mar 8, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk
Copy link
Member

hugovk commented Mar 8, 2024

I have an HTTPS-based clone:

git remote -v
origin  https://github.com/hugovk/cpython.git (fetch)
origin  https://github.com/hugovk/cpython.git (push)
upstream        https://github.com/python/cpython.git (fetch)
upstream        https://github.com/python/cpython.git (push)

And it's still in the UI:

image

The question mark links to:

https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories

Which explains how HTTPS-based clones are supported.

@davidlowryduda
Copy link
Author

Reading through the docs again, I see now that it is possible to use HTTPS if you set up personal access tokens with github. I forgot that this was possible.

I should close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants