Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize "Dynamic analysis with Clang" #1378

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Modernize "Dynamic analysis with Clang" #1378

merged 6 commits into from
Aug 26, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Aug 21, 2024

Remove instructions to build from source.
Clang 18.x or 20.x is much easier to get “normally” than 3.4 was, and it has its own documentation.

Mention the configure options, but keep the previous instructions (seting CC/CXX) as “thorough setup”.

Use the modern option name -fsanitize-ignorelist.

cc @picnixz


📚 Documentation preview 📚: https://cpython-devguide--1378.org.readthedocs.build/

Remove instructions to build from source.
Clang 18.x or 20.x is much easier to get “normally” than 3.4 was,
and it has its own documentation.

Mention the configure options, but keep the previous instructions
(seting CC/CXX) as “thorough setup”.

Use the modern option name `-fsanitize-ignorelist`.
@picnixz picnixz self-requested a review August 21, 2024 11:38
Co-authored-by: Hugo van Kemenade <[email protected]>
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou I love this PR and your detailed improvements. A few small comments but it is fine by me to merge as is. Thank you!

things work as expected. If a library is missing, then you should search for
it in the Clang/LLVM build directory.
After that, run ``make`` and ``make test`` as usual.
Note that ``make`` itself may fail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou Why would we expect make to fail? Perhaps add a small clarification.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @encukou. 🚢

@encukou encukou merged commit ac03915 into python:main Aug 26, 2024
4 checks passed
@encukou encukou deleted the ubsan branch August 26, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants