-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize "Dynamic analysis with Clang" #1378
Conversation
Remove instructions to build from source. Clang 18.x or 20.x is much easier to get “normally” than 3.4 was, and it has its own documentation. Mention the configure options, but keep the previous instructions (seting CC/CXX) as “thorough setup”. Use the modern option name `-fsanitize-ignorelist`.
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@encukou I love this PR and your detailed improvements. A few small comments but it is fine by me to merge as is. Thank you!
development-tools/clang.rst
Outdated
things work as expected. If a library is missing, then you should search for | ||
it in the Clang/LLVM build directory. | ||
After that, run ``make`` and ``make test`` as usual. | ||
Note that ``make`` itself may fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@encukou Why would we expect make
to fail? Perhaps add a small clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @encukou. 🚢
Remove instructions to build from source.
Clang 18.x or 20.x is much easier to get “normally” than 3.4 was, and it has its own documentation.
Mention the configure options, but keep the previous instructions (seting CC/CXX) as “thorough setup”.
Use the modern option name
-fsanitize-ignorelist
.cc @picnixz
📚 Documentation preview 📚: https://cpython-devguide--1378.org.readthedocs.build/