C API: mention the workgroup, and the need to be stricter than our public promises #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Feb 28, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
erlend-aasland
approved these changes
Mar 3, 2025
vstinner
reviewed
Mar 3, 2025
| (:ref:`python:api-intro`). | ||
|
|
||
| Internally, we need to be more careful about compatibility than what we promise | ||
| publicly. See :ref:`public-capi` for details. |
There was a problem hiding this comment.
I don't understand this paragraph. What do you mean by "internally"? The internal C API?
There was a problem hiding this comment.
Perhaps "Within the core development group" is a better phrase than "internally"?
zooba
approved these changes
Mar 3, 2025
encukou
commented
Mar 5, 2025
Comment on lines
+27
to
+28
| Internally, we need to be more careful about compatibility than what we promise | ||
| publicly. See :ref:`public-capi` for details. |
There was a problem hiding this comment.
Would this work?
Suggested change
| Internally, we need to be more careful about compatibility than what we promise | |
| publicly. See :ref:`public-capi` for details. | |
| As core developers, we need to be more careful about compatibility than what | |
| we promise publicly. See :ref:`public-capi` for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now: this refers to an addition to
python:api-introthat I'm proposing in python/cpython#130686📚 Documentation preview 📚: https://cpython-devguide--1524.org.readthedocs.build/