Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos discovered by codespell #18387
Fix typos discovered by codespell #18387
Changes from 1 commit
7d4d964
d598410
caa1a82
546cd98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder if we should just skip the whole
mypy/test/
andmypyc/test
folders entirely.Personally I'd also just move the config to
.pre-commit-config.yaml
directly. Don't think any one is ever running codespell outside pre-commit.This also allows us to use the pre-commit files filter as well with
exclude_types: [pyi, test]
andexclude: ^(mypyc/external/|mypy/test|mypyc/test)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring typos in all tests sounds a bit lazy. I detest those cryptic regex syntaxes and have struggled to make them work when configuring both mypy and black. I much prefer the config of pytest and ruff which do intuitive filtering without
^(|)
which might be great for computers to parse but is suboptimal for those of us that do not have a masters degree in computer science.The point of PEP621 is to concentrate the project config into a canonical file. Some users may choose to run
codespell
on the command line and it would be a shame if they did so without access to the config that was stored in a hidden file.