-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 702 (@deprecated): "normal" overloaded methods #18477
Merged
sobolevn
merged 12 commits into
python:master
from
tyralla:narrowing/overloaded_normal_methods
Jan 28, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2461eff
PEP 702 (@deprecated): "normal" overloaded methods
tyralla 1ba5cf1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7f3d73c
fix inheritance
tyralla a0fcf31
Add tests for class methods and static methods and fix `warn_deprecat…
tyralla 6599d2b
Merge remote-tracking branch 'mypypy/narrowing/overloaded_normal_meth…
tyralla b4a9cd3
`self` --> `cls` for class methods
tyralla 2ff8cf1
less brackets
tyralla 6757391
less brackets
tyralla cc7a915
additional test
tyralla c95f936
execute `check_deprecated` before `warn_deprecated_overload_item` whe…
tyralla 7522cb8
remove `int_or_str` tests
tyralla c758922
refactor: `type.get` instead of loop
tyralla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also test this case:
It should not raise if all is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not raise a warning, but why do you think it should not?
(There is not even a warning for
a.h
, where the implementation is marked as deprecated, which is inconsistent with how functions are handled.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it consistent in c95f936. However, I added the in my opinion missing warnings to the test case, to prevent us from merging this too early by accident. I am curious to hear why you think the current behaviour is correct. (regarding
int_or_str
).