-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Github actions ARM runners for tests #18483
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, looks like it's 1.5x faster cc @JukkaL who will appreciate this :-)
Not sure it's ready for us here quite yet. Last I checked there was an issue with the environment variables, which should be fixed soon. This PR works only due to a temporary fix. I'd also like to wait for a new release of Let's see how it looks next week. Note: The env var issue doesn't effect cibuildwheels which is why we're able to start using the new runner there already. |
b6b734d
to
7fb251b
Compare
This comment has been minimized.
This comment has been minimized.
7fb251b
to
2bd50ec
Compare
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Seems we didn't even need that week. It's ready now. The environment variable issue was resolved Friday and actionlint released a new version with the updated There might still be the occasional issue, e.g. I've read that |
https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/