PEP 810: Update decisions on with blocks and __dict__ reification #4656
+111
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates PEP 810 based on team discussion and feedback: 1. Allow lazy imports inside with blocks - Removed with blocks from syntax restrictions - Added rejected ideas section explaining why restriction was considered 2. __dict__ does not automatically reify lazy imports - Both globals() and __dict__ return raw dictionary without reification - Updated reification section, FAQ, and rejected ideas
pganssle
approved these changes
Oct 13, 2025
| tools and linters are better suited to catch these patterns than hard language | ||
| restrictions. | ||
|
|
||
| Additionally, forbidding explicit ``lazy import`` in ``with`` blocks would |
There was a problem hiding this comment.
I don't think this is any more true than the try/except case, no? It's not really more complexity than the current PEP unless you also have the part where implicit lazy is forced eager in with blocks.
Yhg1s
reviewed
Oct 13, 2025
| does **not** automatically reify lazy imports -- you'll see the lazy proxy | ||
| objects themselves, which you can then manually resolve if needed. | ||
|
|
||
| What's the difference between ``globals()`` and ``mod.__dict__`` for lazy imports? |
There was a problem hiding this comment.
This entire question now doesn't make sense anymore. There isn't a difference between them, is there? Can we just remove this FAQ entry?
Co-authored-by: T. Wouters <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
hugovk
reviewed
Oct 13, 2025
| # Accessing __dict__ from external code DOES reify all lazy imports | ||
| d = my_module.__dict__ | ||
| the object. |
There was a problem hiding this comment.
Lint fix
Suggested change
| the object. | |
| the object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates PEP 810 based on team discussion and feedback:
Allow lazy imports inside with blocks
dict does not automatically reify lazy imports
globals()and__dict__return raw dictionary without reification📚 Documentation preview 📚: https://pep-previews--4656.org.readthedocs.build/