Skip to content

Introduce devcontainers configuration #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 20, 2025

Conversation

gmargaritis
Copy link
Collaborator

Added devcontainers support

Added the following make commands

  1. make http-serve: serve the translation preview on a webserver
  2. make preview: builds and serves the translation preview by opening index.html on the user's browser
  3. make http-preview: builds and serves the translation preview a webserver
  4. make lint: runs powrap and check_spellcheck.py on all .po files

@pygreece/translation I'd vouch to only keep the http-preview command for serving the translation preview.

@gmargaritis gmargaritis requested a review from a team as a code owner November 21, 2024 16:00
@gmargaritis gmargaritis enabled auto-merge (squash) November 21, 2024 18:29
@gmargaritis gmargaritis force-pushed the introduce-devcontainers-config branch from d9ba86e to e9a0e1e Compare November 21, 2024 18:42
@gmargaritis
Copy link
Collaborator Author

Removed http-serve and http-preview and kept their functionality as the default one in the pre-existing commands, i.e. serve, preview.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devcontainer config looks good. Left a couple comments on the Makefile changes and the contributing guide.

@skpanagiotis
Copy link
Collaborator

@gmargaritis πολύ καλή δουλειά, και πιστεύω ότι είναι κάτι που θα εξυπηρετήσει. Εγώ προσωπικά, δεν έχω κάτι να προσθέσω μου φαίνεται μια χαρά, και είναι πολύ καλό που έχουμε 2 τρόπους σεταρίσματος του έργου.

@gmargaritis gmargaritis requested a review from a team November 29, 2024 09:52
Copy link
Collaborator

@skpanagiotis skpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Πιστεύω ότι μπορεί να ενσωματωθεί ως τρόπος.

artemisln and others added 3 commits December 4, 2024 15:29
* Translated distributing/index.po

* Update index.po

* Update index.po

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: = <=>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: skpanagiotis <[email protected]>
@gmargaritis gmargaritis changed the base branch from main to 3.12 December 11, 2024 10:20
@gmargaritis
Copy link
Collaborator Author

@lysnikolaou Can you do a double check and approve this one?

lysnikolaou
lysnikolaou previously approved these changes Feb 20, 2025
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Δύο πολύ minor comments.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmargaritis gmargaritis merged commit 83bec33 into python:3.12 Feb 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants