-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optparse: Fix OptionParser
types
#13339
Open
hamdanal
wants to merge
4
commits into
python:main
Choose a base branch
from
hamdanal:optparse-parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hamdanal
commented
Dec 29, 2024
Comment on lines
-282
to
-305
@overload | ||
def parse_args(self, args: None = None, values: Values | None = None) -> tuple[Values, list[str]]: ... | ||
@overload | ||
def parse_args(self, args: Sequence[AnyStr], values: Values | None = None) -> tuple[Values, list[AnyStr]]: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to explain the double change of parse_args
's args
annotation. Consider this snippet:
import optparse
parser = optparse.OptionParser()
parser.add_option("--target-dir", dest="target_dir", help="Target directory")
values, rest = parser.parse_args(["--target-dir", "/tmp"])
print(values, rest)
if you run it, it prints: {'target_dir': '/tmp'} []
args
is now annotated as a list instead of a sequence. If you make this change to the above snippet:you get:- values, rest = parser.parse_args(["--target-dir", "/tmp"]) + values, rest = parser.parse_args(("--target-dir", "/tmp"))
AttributeError: 'tuple' object has no attribute 'pop'
args
is now a list of strings, notAnyStr
. If you make this change to the above snippet instead:you get:- values, rest = parser.parse_args(["--target-dir", "/tmp"]) + values, rest = parser.parse_args([b"--target-dir", b"/tmp"])
{'target_dir': None} [b'--target-dir', b'/tmp']
This is not an error but it is clearly not what you intended as the program failed to parse the arguments in this case.
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.