-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stubs for cysimdjson #13666
base: main
Are you sure you want to change the base?
Add stubs for cysimdjson #13666
Conversation
Should I changed |
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Looks like stubtest failure is due to cysimdjson not supporting Python 3.13 |
Tests fail only on ubuntu, but windows and macos also use python 3.13 |
stubtest only runs on linux by default. Windows/macos need to be requested by setting The linux run failed because stubtest is running on Python 3.13 but the latest release of cysimdjson only provides wheels for Python 3.12 and below: https://pypi.org/project/cysimdjson/24.12/#files |
There was a ticket here about 3.13 support: TeskaLabs/cysimdjson#55, which got no reply so far. In principle I'm okay with adding these stubs, but at least for the initial commit I'd like to have stubtest support. Maybe @ateska can clarify whether cysimdjson is still supported and 3.13 wheels are planned? |
Hi, |
Yes, using 24.12 was a good idea in this instance, since the library doesn't use semantic versioning. |
related #13640
Deferred: Waiting for upstream 3.13 support: TeskaLabs/cysimdjson#55