Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icalendar] Update to 6.1.2 #13672

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Mar 19, 2025

Finish icalendar.prop annotations

Finish icalendar.prop annotations
@srittau
Copy link
Collaborator Author

srittau commented Mar 19, 2025

If the annotations look a bit wonky and inconsistent then that's because the implementation is wonky and inconsistent. I believe there are a lot of subtle inconsistencies stemming from Python 2 days, where str was silently promoted to unicode (which broke code every two seconds, even if you were careful.)

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
Copy link
Collaborator Author

srittau commented Mar 20, 2025

Fixes #13679.

@srittau srittau linked an issue Mar 20, 2025 that may be closed by this pull request
@hauntsaninja hauntsaninja merged commit e18b99c into python:main Mar 20, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily tests failed on Thu Mar 20 2025
2 participants