Improve passlib.apache

[donBarbos]

No description provided.

[donBarbos]

both check_password functions (in HtpasswdFile and HtdigestFile classes) might return None and it is even in their docstrings, like this:

    def check_password(self, user, password):
        """
        Verify password for specified user.
        If algorithm marked as deprecated by CryptContext, will automatically be re-hashed.

        :returns:
            * ``None`` if user not found.
            * ``False`` if user found, but password does not match.
            * ``True`` if user found and password matches.

        .. versionchanged:: 1.6
            This method was previously called ``verify``, it was renamed
            to prevent ambiguity with the :class:`!CryptContext` method.
            The old alias is deprecated, and will be removed in Passlib 1.8.
        """

[srittau]

Thanks, one thing I noticed below.

[srittau]

While those are initialized to None in the class, they are immediately set in __init__, so they should never be None in instances:

Suggested change

	encoding: str | None
	return_unicode: bool | None
	encoding: str
	return_unicode: bool

[srittau]

While those are initialized to None in the class, they are immediately set in __init__, so they should never be None in instances:

Unfortunately that means we need a stubtest_allowlist entry, but it is what it is.

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

mitmproxy (https://github.com/mitmproxy/mitmproxy)
+ mitmproxy/addons/proxyauth.py:211: error: Incompatible return value type (got "bool | None", expected "bool")  [return-value]