Bump hdbcli to 2.24.* #13705
Bump hdbcli to 2.24.* #13705
Conversation
bump with some improvements
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| @@ -66,7 +66,7 @@ class Cursor: | |||
| def close(self) -> None: ... | |||
| def description_ext(self) -> Sequence[tuple[Any, ...]]: ... | |||
| def execute(self, operation: str, parameters: tuple[Any, ...] | None = ...) -> bool: ... | |||
| def executemany(self, operation: str, parameters: _Parameters = ...) -> Any: ... | |||
| def executemany(self, operation: str, parameters: _Parameters = ..., batcherrors: bool | None = ...) -> Any: ... | |||
There was a problem hiding this comment.
The documentation here reads more like batcherrors: bool = False
Given that the header is executemany(operation, list_of_parameters[, batcherrors=False]) and the syntax is cursor.executemany(<operation>, <list_of_parameters>[, <batcherrors> = {True | False} ])
I think the "optional" in
The method cursor.executemany() has an optional Boolean parameter batcherrors
means that the parameter may be omitted, not that it may be None
There was a problem hiding this comment.
thank you, i'll fix it
| @@ -38,7 +38,7 @@ class Connection: | |||
| def rollback(self) -> None: ... | |||
| def setautocommit(self, auto: bool = ...) -> None: ... | |||
| def setclientinfo(self, key: str, value: str | None = ...) -> None: ... | |||
| def ontrace(self) -> None: ... | |||
| def ontrace(self, callback: Callable[[str], Any], options: str | None) -> None: ... | |||
There was a problem hiding this comment.
Based on the docs, I think options may be omitted here, and if it's present it should be a string.
Something like options: str = ...
bump with some improvements