Added draft chapter to typing spec for tuples. #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…augments existing information about tuples within the type system.
…bounded tuples.
superbobry
reviewed
Jan 21, 2024
superbobry
reviewed
Jan 21, 2024
rchen152
reviewed
Jan 24, 2024
5 tasks
JelleZijlstra
approved these changes
Jan 24, 2024
gvanrossum
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
I'll sign off. I have one English grammar nit.
I also wonder if we ought to say something about sequence unpacking? I recall being confused for a while when trying out some tuple examples in the mypy sandbox until I realized that x: int; y: int; x, y = blah() is very different than xy: tuple[int, int] = blah(). It's probably not on-topic for this section though.
|
I've written conformance tests for the new "tuples" section to see where the four major type checkers deviate from the spec. Results are in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates and augments existing information about tuples within the type system.