-
Notifications
You must be signed in to change notification settings - Fork 262
Update to the Overloads chapter #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
bab532e
First draft of an update to the Overloads chapter.
erictraut de81026
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5ca254e
Updated draft based on initial round of feedback.
erictraut 33c819f
Merge branch 'overloads' of https://github.com/erictraut/typing into …
erictraut f993b28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 660295c
Fixed reference.
erictraut 06c86f1
Merge branch 'overloads' of https://github.com/erictraut/typing into …
erictraut 831945b
Fixed reference.
erictraut 3906a12
Another reference fix.
erictraut bb8fe09
Incorporated PR feedback.
erictraut cce3879
Made changes to proposed overload chapter based on reviewer feedback.
erictraut 7591a4d
Incorporated additional feedback from reviewers.
erictraut 91d4adc
Incorporated more feedback.
erictraut 69d6d4a
Fixed typo in code sample.
erictraut e13dbbe
Update docs/spec/overload.rst
erictraut eed0815
Merge branch 'main' into overloads
carljm 57495db
(very) initial steps on conformance tests
carljm 27f1c79
fix abstractmethod without implementation check
carljm 535075f
split overloads_invalid.py from overloads_basic.py
carljm 8875a4a
add test for final with overload
carljm cb04dd6
add tests for correct usage of override with an overload
carljm 5eabe53
add test for wrong use of override with overload
carljm 484b03c
rename overloads_invalid to overloads_definitions
carljm ac3b70e
add support for stub test files, add overloads_definitions_stub.pyi
carljm 87377ed
add initial overloads_consistency tests
carljm f7bf384
add tests for mixed async-def
carljm 4936ac1
add tests for signature-transforming decorators
carljm e0e0b8a
add test for partially overlapping overloads
carljm cc748d3
add test for fully overlapping overloads
carljm 17d3e15
add tests for step-1 of overload evaluation
carljm 02f0652
add tests for steps 2 and 3 of overload evaluation
carljm f5bee93
add tests for bool expansion (no checker does this)
carljm 169fa58
add tests for enum and tuple expansion
carljm c041484
add test for type[A | B] expansion
carljm c10a72d
add test for step 4 in overload matching
carljm 8a98eae
add test for steps 5/6 in overload matching
carljm 5d22e8d
no expectation of return type if there are call errors
carljm 98f36e8
improve variadic test to not use overlapping overloads
carljm 67c1675
Merge branch 'main' into overloads
erictraut d414386
Apply suggestions from code review
JelleZijlstra f4293e8
Update conformance/tests/overloads_consistency.py
AlexWaygood e835221
Removed section on overlapping overloads. We're struggling to get agr…
erictraut 67768f4
Updated Step 5 of overload algorithm based on PR feedback.
erictraut f292575
Merge branch 'main' into overloads
erictraut babbc6d
Fixed bug in conformance test.
erictraut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.