Skip to content

Fix #2658: Use is not None for boundary_left and boundary_right. #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions arcade/physics_engines.py
Original file line number Diff line number Diff line change
Expand Up @@ -792,12 +792,18 @@ def update(self) -> list[BasicSprite]:
for platform in platform_list:
if platform.change_x != 0 or platform.change_y != 0:
# Check x boundaries and move the platform in x direction
if platform.boundary_left and platform.left <= platform.boundary_left:
if (
platform.boundary_left is not None
and platform.left <= platform.boundary_left
):
platform.left = platform.boundary_left
if platform.change_x < 0:
platform.change_x *= -1

if platform.boundary_right and platform.right >= platform.boundary_right:
if (
platform.boundary_right is not None
and platform.right >= platform.boundary_right
):
platform.right = platform.boundary_right
if platform.change_x > 0:
platform.change_x *= -1
Expand Down
32 changes: 29 additions & 3 deletions tests/unit/physics_engine/test_physics_engine_platformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,22 @@ def test_physics_engine(window):
sprite.center_y = 32
wall_list.append(sprite)

platform_list = arcade.SpriteList[arcade.Sprite]()
platform = arcade.Sprite(
":resources:images/tiles/boxCrate_double.png",
scale=CHARACTER_SCALING,
center_x=64,
center_y=256,
)
platform.boundary_left = 0 # 0 in particular was problematic, see #2658
platform.boundary_right = 128
platform.change_x = 8
platform_list.append(platform)

physics_engine = arcade.PhysicsEnginePlatformer(
character_sprite,
wall_list,
walls=wall_list,
platforms=platform_list,
gravity_constant=GRAVITY,
)

Expand All @@ -48,10 +61,23 @@ def update(td):
assert physics_engine.can_jump() is True
character_sprite.change_y = 15
physics_engine.increment_jump_counter()
window.test()

window.test(frames=7)

assert physics_engine.can_jump() is True
assert platform.center_x == 80 # it bounced against the boundary_right
assert platform.change_x == -8
character_sprite.change_y = 15
physics_engine.increment_jump_counter()
window.test()

window.test(frames=6)

assert physics_engine.can_jump() is False
assert platform.center_x == 32 # right at the boundary
assert platform.change_x == -8 # still going left
physics_engine.disable_multi_jump()

window.test(frames=3)

assert platform.center_x == 32 + 24 # it bounced against the boundary_left
assert platform.change_x == +8
Loading