Abstract the arcade.gl package in order to support different rendering backends #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the
arcade.glpackage and makes the base classes provided by it abstract.It then adds a new
arcade.gl.backendspackage, and moves the existing OpenGL specific functionality intoarcade.gl.backends.gl. This means that in the top levelarcade.glpackage, there is no usage of ctypes or pyglet.gl imports, or any OpenGL specific functionality. It is mostly just defining the base types as abstract classes, and the only functionality provided at that level of the package is things that only operate on the abstract classes.There is a new
providermodule added, which each backend must implement a Provider in order to provide context creation functions.