Skip to content

Conversation

@estyxx
Copy link
Member

@estyxx estyxx commented Jan 20, 2025

What

Replaced dictionary initializations with defaultdict to ensure that any missing keys will not cause a KeyError.

@vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pycon ✅ Ready (Inspect) Visit Preview Jan 20, 2025 2:06pm

@sentry
Copy link

sentry bot commented Jan 20, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: backend/grants/summary.py

Function Unhandled Issue
_aggregate_data_by_country_type KeyError: None /admin/conferences/conference/{obj...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Replaced dictionary initializations with `defaultdict` to ensure that any missing keys will not cause a KeyError.
@estyxx estyxx force-pushed the grants/summary-grants-use-defaultdict branch from 2286be0 to 57aa6e6 Compare January 20, 2025 14:00
@estyxx estyxx enabled auto-merge (squash) January 20, 2025 14:01
@estyxx estyxx merged commit fdfe60d into main Jan 20, 2025
5 of 6 checks passed
@estyxx estyxx deleted the grants/summary-grants-use-defaultdict branch January 20, 2025 14:03
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (e40e524) to head (57aa6e6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4319      +/-   ##
==========================================
- Coverage   94.51%   94.51%   -0.01%     
==========================================
  Files         347      347              
  Lines        9881     9879       -2     
  Branches      692      692              
==========================================
- Hits         9339     9337       -2     
  Misses        455      455              
  Partials       87       87              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants