Fix embedding_dim for fp8 attention #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: By default we set `embedding_dim` to be 3072, but its not expected when ad_head` is also provided as an input to the benchmark resulting in a value error. Differential Revision: D69881611
mandroid6
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mandroid6
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D69881611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: By default we set
embedding_dimto be 3072, but its not expected when ad_head` is also provided as an input to the benchmark resulting in a value error.Differential Revision: D69881611