Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export input/output data to directory #168

Closed
wants to merge 15 commits into from
Closed

Export input/output data to directory #168

wants to merge 15 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Feb 28, 2025 •
edited
Loading

We need to pickle input/output data to directory for numeric checks across runs, such as CUDA version and Triton version.

Test plan:

python run.py --op flash_attention --only triton_tutorial_flash_v2 --num-inputs 1 --export both --export-dir $PWD/flash_attention

python run.py --op flash_attention --only triton_tutorial_flash_v2 --num-inputs 1 --export both --export-dir .data/flash_attention/ --bwd --causal

ls .data/flash_attention

-rw-r--r-- 1 xzhao9 users 9438227 Feb 28 07:40 'x_(4, 48, 128, 64)-input.pkl'
-rw-r--r-- 1 xzhao9 users 9438257 Feb 28 07:39 'x_(4, 48, 128, 64)-triton_tutorial_flash_v2-bwd-grad.pkl'
-rw-r--r-- 1 xzhao9 users 3146151 Feb 28 07:40 'x_(4, 48, 128, 64)-triton_tutorial_flash_v2-fwd-output.pkl'

Fixes #84

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload February 28, 2025 15:43 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload February 28, 2025 15:43 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 requested a review from adamomainz February 28, 2025 15:43
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload February 28, 2025 16:00 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload February 28, 2025 16:00 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in fb5e940.

@xuzhao9 xuzhao9 deleted the xz9/add-export branch March 13, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamomainz adamomainz Awaiting requested review from adamomainz

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix backward accuracy
2 participants
@xuzhao9 @facebook-github-bot