-
Notifications
You must be signed in to change notification settings - Fork 591
Update matmul_fp8_row_meta signature #4168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This pull request was exported from Phabricator. Differential Revision: D75030969 |
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
May 21, 2025
Summary: X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
Summary: Matches Bias support with the non-persistent kernel. Differential Revision: D74914575
85b7274
to
e24f01c
Compare
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
May 28, 2025
Summary: X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
May 28, 2025
Summary: X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
May 28, 2025
Summary: X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
e24f01c
to
facca3c
Compare
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
May 28, 2025
Summary: X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
This pull request was exported from Phabricator. Differential Revision: D75030969 |
facca3c
to
ab3c57f
Compare
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
May 28, 2025
Summary: Pull Request resolved: pytorch#4168 X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
Summary: Pull Request resolved: pytorch#4168 X-link: facebookresearch/FBGEMM#1248 Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row. Differential Revision: D75030969
This pull request was exported from Phabricator. Differential Revision: D75030969 |
ab3c57f
to
64087e0
Compare
This pull request has been merged in 4f98876. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1248
Updates the signature to matmul_fp8_row_meta to be consistent with matmul_fp8_row.
Differential Revision: D75030969