Pass the updated embeddings to EmbeddingKVDB #4210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D73819097 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
May 29, 2025
Summary: X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Jun 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Jun 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Jun 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Jun 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
|
This pull request was exported from Phabricator. Differential Revision: D73819097 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: pytorch#4210 X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
Summary: Pull Request resolved: pytorch#4210 X-link: facebookresearch/FBGEMM#1285 Added the functions `stream_cuda/stream`. - When `blocking_tensor_copy=false` Create a new thread to execute the callback registered via the `stream_cuda` the reason as in comment. this is based on [the findings that callbacks are executed in serialized manner]( https://fb.workplace.com/permalink.php?story_fbid=pfbid02s7RWvRZ4g2nS5i42kkyApvLsCbiRpGrdAEPs2p5qr2MDnq5YbgfThQ6PXSB6y13Al&id=100026528794331) - When `blocking_tensor_copy=true` just copy and enqueue in the callback thread. Added profile to the callback functions. Added the function `stream_sync_cuda` - To explicitly join the async copy thread to make sure the copy is happened before the buffer got overwritten again. Reviewed By: q10 Differential Revision: D73819097
|
This pull request was exported from Phabricator. Differential Revision: D73819097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1285
Added the functions
stream_cuda/stream.blocking_tensor_copy=falseCreate a new thread to execute the callback registered via thestream_cudathe reason as in comment. this is based on the findings that callbacks are executed in serialized mannerblocking_tensor_copy=truejust copy and enqueue in the callback thread.Added profile to the callback functions.
Added the function
stream_sync_cudaReviewed By: q10
Differential Revision: D73819097