Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for ITensor weight in convolution and fix related bug #3327

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add test case for ITensor weight in convolution and fix related bug #3327

merged 1 commit into from
Dec 17, 2024

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented Dec 17, 2024 •
edited
Loading

Description

Added a test case for convolution with ITensor weight and fixed a bug related to handling Conv1d weight unsqueezing in the converter.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 added the component: converters Issues re: Specific op converters label Dec 17, 2024
@chohk88 chohk88 self-assigned this Dec 17, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Dec 17, 2024
@chohk88 chohk88 linked an issue Dec 17, 2024 that may be closed by this pull request
[Coverage] For torch.ops.aten.convolution, Error Code 3: API Usage Error (Parameter check failed, condition: nbSpatialDims == 2 || nbSpatialDims == 3. ) #3326
Closed
peri044
peri044 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 7767594 into main Dec 17, 2024
70 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@chohk88 chohk88

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
3 participants
@chohk88 @peri044 @facebook-github-bot