Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLFW changes 25.01 onwards #3356

Merged
merged 4 commits into from
Mar 15, 2025
Merged

DLFW changes 25.01 onwards #3356

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff2dd9b
DLFW changes 25.01 onwards
apbose Jan 15, 2025
783b13e
undoing the noxfile change with PR 3369 in main
apbose Feb 24, 2025
0039841
ubuntu22.04 change- this needs to be in main
apbose Jan 16, 2025
7aea483
addressing review comments
apbose Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/util/Exception.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
#if defined(__GNUC__) && !defined(__clang__)
#if __GNUC__ >= 13
#include <cstdint>
#endif
#elif defined(__clang__)
#if __clang_major__ >= 13
#include <cstdint>
#endif
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to

// Include cstdint for GCC 13+ or Clang 13+
#if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ >= 13)) || \
    (defined(__clang__) && (__clang_major__ >= 13))
    #include <cstdint>
#endif

#pragma once

#include <exception>
Expand Down
1 change: 0 additions & 1 deletion examples/int8/training/vgg16/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ tensorboard>=1.14.0
protobuf==3.20.*
nvidia-pyindex
--extra-index-url https://pypi.nvidia.com
pytorch-quantization
tqdm
nvidia-modelopt
--extra-index-url https://pypi.nvidia.com
4 changes: 2 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# Use system installed Python packages
PYT_PATH = (
"/usr/local/lib/python3.10/dist-packages"
"/usr/local/lib/python3.12/dist-packages"
if not "PYT_PATH" in os.environ
else os.environ["PYT_PATH"]
)
Expand Down Expand Up @@ -34,7 +34,7 @@
# Set epochs to train VGG model for accuracy tests
EPOCHS = 25

SUPPORTED_PYTHON_VERSIONS = ["3.9", "3.10", "3.11", "3.12"]
SUPPORTED_PYTHON_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.12"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we dont support py 3.7, 3.8 anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will remove them then


nox.options.sessions = [
"l0_api_tests-" + "{}.{}".format(sys.version_info.major, sys.version_info.minor)
Expand Down
4 changes: 2 additions & 2 deletions tests/py/ts/ptq/test_ptq_dataloader_calibrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import torch
import torch.nn as nn
import torch_tensorrt as torchtrt
import torch_tensorrt.ts.ptq as PTQ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to have but we should drop these tests from DLFW as this API is being deprecated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are dropped in DLFW

import torchvision
import torchvision.transforms as transforms
import torch_tensorrt.ts.ptq as PTQ
from torch.nn import functional as F
from torch_tensorrt.ts.logging import *

Expand All @@ -15,7 +15,7 @@ def find_repo_root(max_depth=10):
dir_path = os.path.dirname(os.path.realpath(__file__))
for i in range(max_depth):
files = os.listdir(dir_path)
if "WORKSPACE" in files:
if "MODULE.bazel" in files:
return dir_path
else:
dir_path = os.path.dirname(dir_path)
Expand Down
5 changes: 2 additions & 3 deletions tests/py/ts/ptq/test_ptq_trt_calibrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import unittest

import tensorrt as trt
import torch
import torch.nn as nn
import torch_tensorrt as torchtrt
Expand All @@ -9,14 +10,12 @@
from torch.nn import functional as F
from torch_tensorrt.ts.logging import *

import tensorrt as trt


def find_repo_root(max_depth=10):
dir_path = os.path.dirname(os.path.realpath(__file__))
for i in range(max_depth):
files = os.listdir(dir_path)
if "WORKSPACE" in files:
if "MODULE.bazel" in files:
return dir_path
else:
dir_path = os.path.dirname(dir_path)
Expand Down
Loading