Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updated cuda graphs doc #3357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: Updated cuda graphs doc #3357

wants to merge 2 commits into from

Conversation

keehyuna
Copy link
Collaborator

Description

Updated cuda graphs document

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added documentation Improvements or additions to documentation component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 15, 2025
@github-actions github-actions bot requested a review from gs-olive January 15, 2025 11:46
@keehyuna keehyuna requested review from narendasan and peri044 and removed request for gs-olive January 15, 2025 11:47
keehyuna
keehyuna commented Jan 15, 2025
View reviewed changes
py/torch_tensorrt/dynamo/runtime/_CudaGraphsTorchTensorRTModule.py
self._input_buffers[i] = contiguous_inputs[i].clone()
else:
self._input_buffers[i].copy_(contiguous_inputs[i])
if need_cudagraphs_record:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed wrong indent.

@keehyuna keehyuna self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@peri044 peri044 Awaiting requested review from peri044

Assignees

@keehyuna keehyuna

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keehyuna @narendasan @facebook-github-bot