Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: flip use_cxx11_abi naming #3361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: flip use_cxx11_abi naming #3361

wants to merge 1 commit into from
+58 −60

Conversation

zewenli98
Copy link
Collaborator

Description

flip use_cxx11_abi naming

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jan 18, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation component: build system Issues re: Build system component: api [Python] Issues re: Python API labels Jan 18, 2025
@github-actions github-actions bot requested a review from gs-olive January 18, 2025 02:33
@zewenli98 zewenli98 removed the request for review from gs-olive January 18, 2025 02:34
@zewenli98 zewenli98 mentioned this pull request Jan 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

@lanluo-nvidia lanluo-nvidia Awaiting requested review from lanluo-nvidia

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zewenli98 @facebook-github-bot