Nccl ops correction changes #3387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: lowering
peri044
reviewed
Feb 11, 2025
Comment on lines
68
to
76
| # transpose key deleted since not desirable to lower it to permute | ||
| to_delete = { | ||
| key | ||
| for key in settings_aot_autograd["decompositions"] | ||
| if "detach" in key._name or "transpose" in key._name | ||
| } | ||
|
|
||
| for key in to_delete: | ||
| del settings_aot_autograd["decompositions"][key] |
There was a problem hiding this comment.
we have a remove_detach lowering pass. Can that help here ?
narendasan
reviewed
Feb 18, 2025
| if aten.detach in settings_aot_autograd["decompositions"]: | ||
| del settings_aot_autograd["decompositions"][aten.detach] | ||
| # transpose key deleted since not desirable to lower it to permute | ||
| to_delete = { |
There was a problem hiding this comment.
Will this apply to all cases not just NCCL?
There was a problem hiding this comment.
You mean in the non distributed example? I am not sure about that answer, I added this for the llama3 example since I was issues in the model lowering and it was generating graph breaks at the wrong part, leading to complex input error. It can be added to all cases in case if we want to not lower transpose to permute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.