Cpu memory graph break #3886
Open
Cpu memory graph break #3886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/_compiler.py 2025-11-04 20:05:23.825034+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/_compiler.py 2025-11-04 20:05:55.253944+00:00
@@ -876,15 +876,14 @@
# This is done to release CPU memory.
for attr in dir(gm):
if attr.startswith("_frozen_param"):
delattr(gm, attr)
-
-
from torch_tensorrt.dynamo.conversion._ConverterRegistry import DYNAMO_CONVERTERS
+
DYNAMO_CONVERTERS.disallowed_targets = set()
-
+
for name, _ in partitioned_module.named_children():
submodule = getattr(partitioned_module, name)
# filter on the GraphModule
if not isinstance(submodule, torch.fx.graph_module.GraphModule):
continue
narendasan
reviewed
Nov 4, 2025
|
|
||
| logger = logging.getLogger(__name__) | ||
| NON_BREAKABLE_OP_LISTS = [ | ||
| ["addmm", "addmm"], |
There was a problem hiding this comment.
Just a note for implementation later.
- this should use an actual subgraph definition
- it should use pytorch op targets not strings
addmmshould be decomposed right so the graph we want ismm->add- There should be a user facing API to modify this list similar to what we have for passes
|
|
||
| def calculate_num_of_break(self, subgraphs: List[Subgraph]) -> int: | ||
|
|
||
| def calculate_size_budget( |
There was a problem hiding this comment.
Should there be an API to define this manually?
There was a problem hiding this comment.
Yeah I think so. For now you can just hardcode and play with it
| This function breaks the subgraphs into smaller subgraphs at the specified frequency to save CPU memory. | ||
| """ | ||
| op_to_break = "add." | ||
| op_to_break = "addmm." |
There was a problem hiding this comment.
This function is not called. I just left there for experiment and would delete later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: