-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use exp2 for mx scaling #1530
Open
drisspg
wants to merge
1
commit into
main
Choose a base branch
from
drisspg/stack/26
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use exp2 for mx scaling #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1530
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 9d068d5 with merge base 11333ba (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 9, 2025 00:28
29300f9
to
75587ff
Compare
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 9, 2025
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 9, 2025 00:29
75587ff
to
a0db83c
Compare
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 9, 2025 00:29
a0db83c
to
5bb2abf
Compare
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 9, 2025 17:33
5bb2abf
to
ffef385
Compare
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 9, 2025 17:37
ffef385
to
71e43d3
Compare
vkuzo
reviewed
Jan 9, 2025
torch.full(max_abs.size(), 2.0, device=scale_e8m0_biased.device), | ||
scale_e8m0_unbiased, | ||
) | ||
scale_fp = torch.exp2(scale_e8m0_unbiased).to(torch.float32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about torch.exp2
vkuzo
approved these changes
Jan 9, 2025
should ensure CI is green though |
drisspg
added a commit
that referenced
this pull request
Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 9, 2025 22:30
71e43d3
to
6238167
Compare
drisspg
added
the
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
label
Jan 15, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg
force-pushed
the
drisspg/stack/26
branch
from
January 15, 2025 02:47
6238167
to
9d068d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Use exp2 for mx scaling