-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libOMP linking for experimental kernels #1828
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1828
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 4da1fed with merge base ffb4350 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Looks like just removing the omp link isn't enough. It can't find some omp related ops
Note: This is unrelated (most likely) to the failures on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work unless libomp.dylib is included in TORCH_LIBRARIES. CI is failing as well.
Remake of #1822
As mentioned in pytorch/torchchat#1493, we no longer need to explicitly link to OMP libs.