Add stack for qkv projection #1848
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1848
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2aa9130 with merge base ffb4350 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
reviewed
Mar 7, 2025
| # Handle scales based on their dimensionality | ||
| if all(t.scale.ndim == 0 for t in tensors): | ||
| # Use the maximum scale value from all tensors for numerical stability | ||
| stacked_scale = torch.max(torch.cat([t.scale for t in tensors])) |
There was a problem hiding this comment.
would this change numerics if max_scale != original scale? I would have expected something like a rescale of the data if the scale is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.