-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Initial prototype of differentiable grouped_scaled_mm function for torchao #1969
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1969
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 281950c with merge base 923242e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
7244136
to
a761549
Compare
7afbe08
to
8d15a8a
Compare
8268b63
to
cced381
Compare
a472122
to
4e04022
Compare
0dc4c7f
to
4c5e9db
Compare
7042cef
to
c19bc88
Compare
None, | ||
0, | ||
-1, | ||
-2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewer: we need to allow expand this constraint so we can do rowwise scaling of the 2D subtensors embedded in 3D tensors.
e.g.
- A = (M,K) and B = (B,K,N)
- A_scale should be (M,)
- B_scale should be (B,N) <-- because we computed rowwise scales for the (K,N) subtensors
Summary
The
_grouped_scaled_mm
function in torchao will do:Test plan