Skip to content

Patch the _is_conv_node function #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Patch the _is_conv_node function #2257

merged 1 commit into from
May 31, 2025

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented May 23, 2025

Summary: Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Differential Revision: D75323215

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2257

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 69a6a5f with merge base c4250a4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

cccclai added a commit to cccclai/ao that referenced this pull request May 23, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
d1efd20 
Summary:

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Differential Revision: D75323215
@cccclai cccclai force-pushed the export-D75323215 branch from 3decd5b to d1efd20 Compare May 23, 2025 22:52
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

cccclai added a commit to cccclai/ao that referenced this pull request May 24, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
677287a 
Summary:

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Differential Revision: D75323215
@cccclai cccclai force-pushed the export-D75323215 branch from d1efd20 to 677287a Compare May 24, 2025 17:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

@cccclai
Copy link
Contributor Author

cccclai commented May 24, 2025

It seems like I can't add reviews. Also can't add labels.

cccclai added a commit to cccclai/ao that referenced this pull request May 27, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
02763b6 
Summary:

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Differential Revision: D75323215
@cccclai cccclai force-pushed the export-D75323215 branch from 677287a to 02763b6 Compare May 27, 2025 21:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

cccclai added a commit to cccclai/ao that referenced this pull request May 27, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
0359057 
Summary:
Pull Request resolved: pytorch#2257

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Differential Revision: D75323215
@cccclai cccclai force-pushed the export-D75323215 branch from 02763b6 to 0359057 Compare May 27, 2025 21:19
@cccclai cccclai mentioned this pull request May 28, 2025
Closed
cccclai added a commit to cccclai/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function
cddf2ca 
Summary: Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
@cccclai cccclai mentioned this pull request May 28, 2025
Closed
pytorch-bot bot pushed a commit to pytorch/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (#154473)
e8ebd48 
Summary:

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
cccclai added a commit to cccclai/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
257cf94 
Summary:

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
cccclai added a commit to cccclai/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
20fdebb 
Summary:

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
cccclai added a commit to cccclai/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
e80a210 
Summary:
Pull Request resolved: pytorch#154473

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
cccclai added a commit to cccclai/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
2730754 
Summary:
Pull Request resolved: pytorch#154473

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
@HDCharles HDCharles added topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) topic: new feature Use this tag if this PR adds a new feature and removed topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) labels May 29, 2025
cccclai added a commit to cccclai/pytorch that referenced this pull request May 29, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
e71e444 
Summary:

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
@cccclai cccclai force-pushed the export-D75323215 branch from 0359057 to f39c46e Compare May 29, 2025 21:51
cccclai added a commit to cccclai/ao that referenced this pull request May 29, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
f39c46e 
Summary:

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Differential Revision: D75323215
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request May 30, 2025
@cccclai @pytorchmergebot
[Reland][pytorch] Patch the _is_conv_node function (#154473)
9371491 
Summary: Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468

Pull Request resolved: #154473
Approved by: https://github.com/Skylion007
@cccclai cccclai force-pushed the export-D75323215 branch from f39c46e to e80270d Compare May 30, 2025 19:24
cccclai added a commit to cccclai/ao that referenced this pull request May 30, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
e80270d 
Summary:

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Reviewed By: HDCharles

Differential Revision: D75323215
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

cccclai added a commit to cccclai/ao that referenced this pull request May 30, 2025
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
3e644c7 
Summary:

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Reviewed By: HDCharles

Differential Revision: D75323215
@cccclai cccclai force-pushed the export-D75323215 branch from e80270d to 3e644c7 Compare May 30, 2025 20:50
@cccclai @facebook-github-bot
Patch the _is_conv_node function (pytorch#2257)
69a6a5f 
Summary:
Pull Request resolved: pytorch#2257

Add the conv padding ops in torch/ao only, will add a separate PR for the ones in pytorch

Reviewed By: HDCharles

Differential Revision: D75323215
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75323215

@cccclai cccclai force-pushed the export-D75323215 branch from 3e644c7 to 69a6a5f Compare May 30, 2025 20:54
@facebook-github-bot facebook-github-bot merged commit e51ffd9 into pytorch:main May 31, 2025
18 of 21 checks passed
nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request Jun 2, 2025
@cccclai @nWEIdia
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
2b47272 
Summary: Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468

Pull Request resolved: pytorch#154473
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDCharles HDCharles HDCharles approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: new feature Use this tag if this PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cccclai @facebook-github-bot @HDCharles