-
Notifications
You must be signed in to change notification settings - Fork 275
Fix Bug in MX Builds #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug in MX Builds #2284
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2284
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 919480d with merge base e51ffd9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
stack-info: PR: #2284, branch: drisspg/stack/62
This fixes it but there is another problem that is if no torch_cuda_arch_list is set the cutlass files dont' get build... |
Actually as long as we have a sufficiently new CUDA toolkit (12.8 I think?), we can compile for sm100a? Regardless of actual compute capability available at compile time. The downside is that compile time is longer for non-sm100a users building from source. |
So there was 2 problems:
I think the problem right now is that I unconditionally remove remove the sources e.g. INFO:root:copying build/lib.linux-x86_64-cpython-312/torchao/_C.abi3.so -> torchao which is right ahh its just 90a nd 100a are not in the arch_flags w/ no TORCH_CUDA_ARCHLIST set |
stack-info: PR: #2284, branch: drisspg/stack/62
Stacked PRs:
Fix Bug in MX Builds