Make QuantizeTensorToFloat8Kwargs a frozen Dataclass to enable torch export#4011
Closed
asfiyab-nvidia wants to merge 1 commit intopytorch:mainfrom
Closed
Make QuantizeTensorToFloat8Kwargs a frozen Dataclass to enable torch export#4011asfiyab-nvidia wants to merge 1 commit intopytorch:mainfrom
asfiyab-nvidia wants to merge 1 commit intopytorch:mainfrom
Conversation
…export Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4011
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b491570 with merge base 5a5029d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Author
|
@jcaip can you please help with the review? Thanks |
jcaip
reviewed
Mar 6, 2026
Contributor
jcaip
left a comment
There was a problem hiding this comment.
Thanks for the fix @asfiyab-nvidia. Can we also add an export test to test/quantization/quantize_/workflows/float8/test_float8_tensor.py so that this doesn't happen again?
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regular Dataclasses are not supported by the Dynamo Tracer as they're dispatched to
UserDefinedObjectVariablewhich doesn't have an implementation foras_proxy. However, Frozen Dataclasses are supported by the Dynamo Tracer as theas_proxymethod is defined for them (source).Marking
QuantizeTensorToFloat8Kwargsas a frozen dataclass enables torch.export on theFloat8Tensorsubclass.Fixes #3928