Skip to content

Upgrade torchao build configs to C++20 #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-barnes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade torchao build configs to C++20 #4025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,12 +523,12 @@ def get_extensions():
"-DNDEBUG" if not debug_mode else "-DDEBUG",
"-O3" if not debug_mode else "-O0",
"-t=0",
"-std=c++17",
"-std=c++20",
]
rocm_args = [
"-DNDEBUG" if not debug_mode else "-DDEBUG",
"-O3" if not debug_mode else "-O0",
"-std=c++17",
"-std=c++20",
]
maybe_hipify_v2_flag = []
if use_rocm and detect_hipify_v2():
Expand Down Expand Up @@ -772,7 +772,7 @@ def get_extensions():
extra_compile_args={
"cxx": [
f"-DPy_LIMITED_API={min_supported_cpython_hexcode}",
"-std=c++17",
"-std=c++20",
"-O3",
],
"nvcc": nvcc_args
Expand Down
2 changes: 1 addition & 1 deletion torchao/csrc/cpu/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ include(CMakeDependentOption)

project(torchao)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)

if (NOT CMAKE_BUILD_TYPE)
set(CMAKE_BUILD_TYPE Release)
Expand Down
2 changes: 1 addition & 1 deletion torchao/experimental/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ include(CMakeDependentOption)

project(torchao)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)

if (NOT CMAKE_BUILD_TYPE)
set(CMAKE_BUILD_TYPE Release)
Expand Down
2 changes: 1 addition & 1 deletion torchao/experimental/kernels/mps/test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
all: test_lowbit

test_lowbit: test_lowbit.mm ../src/OperationUtils.mm
clang++ -I${TORCHAO_ROOT} -O3 -std=c++17 -Wall -Wextra -o $@ $^ -framework Metal -framework Foundation
clang++ -I${TORCHAO_ROOT} -O3 -std=c++20 -Wall -Wextra -o $@ $^ -framework Metal -framework Foundation

run: test_lowbit
./test_lowbit
2 changes: 1 addition & 1 deletion torchao/experimental/ops/mps/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ cmake_minimum_required(VERSION 3.19)

project(torchao_ops_mps_linear_fp_act_xbit_weight)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED YES)

if (NOT CMAKE_BUILD_TYPE)
Expand Down
Loading