kernel: synchronize autotuner cache updates#4554
Open
nascheme wants to merge 1 commit into
Open
Conversation
Protect the autotuner cache lazy load and miss-path writes with an explicit lock, and save a snapshot so pickle never iterates a dict while another thread mutates it. Assisted-by: Claude Opus 4.7
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4554
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_best_config_fnintorchao/kernel/autotuner.pyhad a lazy-init-then-read-modify-write on the module-levelBEST_CONFIGSdict, followed by_save_best_configs(BEST_CONFIGS)pickling it directly. Under free-threaded Python this is a check-then-act race on init, pluspickle.dumpcan iterate the dict while another thread is still inserting into it.Guard lazy init and the miss-path write with a lock, and pickle a snapshot taken under that same lock rather than the live dict.