[TorchAudio][stream_reader] Make StreamingMediaDecoderBytes available for C++ usage #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3742
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
milan-zhou
pushed a commit
to milan-zhou/audio
that referenced
this pull request
Feb 8, 2024
… for C++ usage (pytorch#3742) Summary: This diff moves `StreamingMediaDecoderBytes` from the `pybind` file to the `stream_reader` files, enabling usage for all C++ use cases. We can similarly migrate the `StreamingMediaDecoderFile` and `StreamingMediaEncoderFile` in the future. Interestingly we do not have a `StreamingMediaEncoderBytes` implementation. Differential Revision: D53585768
milan-zhou
force-pushed
the
export-D53585768
branch
from
2f35047 to
3500ab4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
|
@milan-zhou has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
milan-zhou
added a commit
to milan-zhou/audio
that referenced
this pull request
Feb 9, 2024
…e for C++ usage (pytorch#3742) Summary: This diff moves `StreamingMediaDecoderBytes` from the `pybind` file to the `stream_reader` files, enabling usage for all C++ use cases. We can similarly migrate the `StreamingMediaDecoderFile` and `StreamingMediaEncoderFile` in the future. Interestingly we do not have a `StreamingMediaEncoderBytes` implementation. Reviewed By: jeremyteboul Differential Revision: D53585768 Pulled By: milan-zhou
milan-zhou
force-pushed
the
export-D53585768
branch
from
0ed81e6 to
1712ad2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
milan-zhou
added a commit
to milan-zhou/audio
that referenced
this pull request
Feb 9, 2024
…e for C++ usage (pytorch#3742) Summary: This diff moves `StreamingMediaDecoderBytes` from the `pybind` file to the `stream_reader` files, enabling usage for all C++ use cases. We can similarly migrate the `StreamingMediaDecoderFile` and `StreamingMediaEncoderFile` in the future. Interestingly we do not have a `StreamingMediaEncoderBytes` implementation. Reviewed By: jeremyteboul Differential Revision: D53585768 Pulled By: milan-zhou
milan-zhou
force-pushed
the
export-D53585768
branch
from
1712ad2 to
e32a668
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
milan-zhou
added a commit
to milan-zhou/audio
that referenced
this pull request
Feb 9, 2024
…e for C++ usage (pytorch#3742) Summary: This diff moves `StreamingMediaDecoderBytes` from the `pybind` file to the `stream_reader` files, enabling usage for all C++ use cases. We can similarly migrate the `StreamingMediaDecoderFile` and `StreamingMediaEncoderFile` in the future. Interestingly we do not have a `StreamingMediaEncoderBytes` implementation. Reviewed By: jeremyteboul Differential Revision: D53585768 Pulled By: milan-zhou
milan-zhou
force-pushed
the
export-D53585768
branch
from
e32a668 to
6b8765d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
…e for C++ usage (pytorch#3742) Summary: This diff moves `StreamingMediaDecoderBytes` from the `pybind` file to the `stream_reader` files, enabling usage for all C++ use cases. We can similarly migrate the `StreamingMediaDecoderFile` and `StreamingMediaEncoderFile` in the future. Interestingly we do not have a `StreamingMediaEncoderBytes` implementation. Reviewed By: jeremyteboul Differential Revision: D53585768 Pulled By: milan-zhou
milan-zhou
force-pushed
the
export-D53585768
branch
from
6b8765d to
6de23f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53585768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves
StreamingMediaDecoderBytesfrom thepybindfile to thestream_readerfiles, enabling usage for all C++ use cases.We can similarly migrate the
StreamingMediaDecoderFileandStreamingMediaEncoderFilein the future. Interestingly we do not have aStreamingMediaEncoderBytesimplementation.Differential Revision: D53585768