Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better Error for initializers on intra-point constraints #2775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamuelGabriel
Copy link
Contributor

Summary: I have added the wanted exception.

Differential Revision: D71204155

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (44b6400) to head (557e2e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         202      202           
  Lines       18508    18513    +5     
=======================================
+ Hits        18507    18512    +5     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 17, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 17, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 17, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 17, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 17, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 17, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 18, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 18, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:

I have added the wanted exception.

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Differential Revision: D71204155
SamuelGabriel added a commit to SamuelGabriel/botorch that referenced this pull request Mar 19, 2025
…#2775)

Summary:

I have added the wanted exception.

Reviewed By: esantorella

Differential Revision: D71204155
…#2775)

Summary:
Pull Request resolved: pytorch#2775

I have added the wanted exception.

Reviewed By: esantorella

Differential Revision: D71204155
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71204155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants