Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socket timeout in test_data_parallel #1522

Closed
wants to merge 1 commit into from

Conversation

sarahtranfb
Copy link
Contributor

Summary:
Example failure:
https://www.internalfb.com/intern/testinfra/testconsole/testrun/4785074873255877/
Passed and failed on rev 3c307b1e123f2007d69464836099b12fa4656423, so not due to a code change

Running locally at least, I see:

E0305 00:39:14.685009 1133092 socket.cpp:1019] [c10d] The client socket has timed out after 600000ms while trying to connect to (127.0.0.1, 29500).

Related thread: https://fb.workplace.com/groups/319878845696681/permalink/1241443370206886/

There's only one process in this test (world_size=1) so should be ok to use localhost instead of 127.0.0.1

Differential Revision: D70637306

Summary:
Example failure:
https://www.internalfb.com/intern/testinfra/testconsole/testrun/4785074873255877/
Passed and failed on rev 3c307b1e123f2007d69464836099b12fa4656423, so not due to a code change

Running locally at least, I see:
```
E0305 00:39:14.685009 1133092 socket.cpp:1019] [c10d] The client socket has timed out after 600000ms while trying to connect to (127.0.0.1, 29500).
```

Related thread: https://fb.workplace.com/groups/319878845696681/permalink/1241443370206886/

There's only one process in this test (`world_size=1`) so should be ok to use `localhost` instead of `127.0.0.1`

Differential Revision: D70637306
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70637306

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b40db68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants