Enable aggregate mode for any case where perturbations_per_eval == 1 #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Shapley Values currently have issues with per task importance, since aggregate mode returns more than 1 output with perturbations per eval = 1, which should apply aggregate mode for collating perturbation results. Updates logic to appropriately handle multiple outputs (not matching batch size) when perturbations per eval = 1 Differential Revision: D70832826
|
This pull request was exported from Phabricator. Differential Revision: D70832826 |
vivekmig
force-pushed
the
export-D70832826
branch
from
3574bf1 to
51ef4e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70832826 |
|
This pull request has been merged in 4ca5c2c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Shapley Values currently have issues with per task importance, since aggregate mode returns more than 1 output with perturbations per eval = 1, which should apply aggregate mode for collating perturbation results.
Updates logic to appropriately handle multiple outputs (not matching batch size) when perturbations per eval = 1
Differential Revision: D70832826