Avoid unnecessary tensor construction when creating input masks for permutation/ablation #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D71057703 |
sarahtranfb
force-pushed
the
export-D71057703
branch
from
49cee98 to
8b50d9e
Compare
sarahtranfb
added a commit
to sarahtranfb/captum
that referenced
this pull request
Mar 12, 2025
…ermutation/ablation (pytorch#1527) Summary: Study: https://docs.google.com/spreadsheets/d/1GyNJJBrNkazGOyJQLv00QV4phX2R3488oNgVPT17qzU/edit?gid=0#gid=0 Saw a regression in the new logic introduced in D69531512 with one of the models for both permutation and ablation methods, potentially due to large sparse features. vivekmig suggested we can avoid creating all these zero tensors Differential Revision: D71057703
|
This pull request was exported from Phabricator. Differential Revision: D71057703 |
sarahtranfb
added a commit
to sarahtranfb/captum
that referenced
this pull request
Mar 12, 2025
…ermutation/ablation (pytorch#1527) Summary: Pull Request resolved: pytorch#1527 Study: https://docs.google.com/spreadsheets/d/1GyNJJBrNkazGOyJQLv00QV4phX2R3488oNgVPT17qzU/edit?gid=0#gid=0 Saw a regression in the new logic introduced in D69531512 with one of the models for both permutation and ablation methods, potentially due to large sparse features. vivekmig suggested we can avoid creating all these zero tensors Differential Revision: D71057703
sarahtranfb
force-pushed
the
export-D71057703
branch
from
8b50d9e to
0c6a39e
Compare
sarahtranfb
added a commit
to sarahtranfb/captum
that referenced
this pull request
Mar 13, 2025
…ermutation/ablation (pytorch#1527) Summary: Study: https://docs.google.com/spreadsheets/d/1GyNJJBrNkazGOyJQLv00QV4phX2R3488oNgVPT17qzU/edit?gid=0#gid=0 Saw a regression in the new logic introduced in D69531512 with one of the models for both permutation and ablation methods, potentially due to large sparse features. vivekmig suggested we can avoid creating all these zero tensors Reviewed By: craymichael Differential Revision: D71057703
sarahtranfb
force-pushed
the
export-D71057703
branch
from
0c6a39e to
5f9d5da
Compare
…ermutation/ablation (pytorch#1527) Summary: Pull Request resolved: pytorch#1527 Study: https://docs.google.com/spreadsheets/d/1GyNJJBrNkazGOyJQLv00QV4phX2R3488oNgVPT17qzU/edit?gid=0#gid=0 Saw a regression in the new logic introduced in D69531512 with one of the models for both permutation and ablation methods, potentially due to large sparse features. vivekmig suggested we can avoid creating all these zero tensors Reviewed By: craymichael Differential Revision: D71057703
|
This pull request was exported from Phabricator. Differential Revision: D71057703 |
sarahtranfb
force-pushed
the
export-D71057703
branch
from
5f9d5da to
1aab81a
Compare
|
This pull request has been merged in b917b2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Study: https://docs.google.com/spreadsheets/d/1GyNJJBrNkazGOyJQLv00QV4phX2R3488oNgVPT17qzU/edit?gid=0#gid=0
Saw a regression in the new logic introduced in D69531512 with one of the models for both permutation and ablation methods, potentially due to large sparse features. vivekmig suggested we can avoid creating all these zero tensors
Differential Revision: D71057703