Skip to content

Run integration tests after prod deployment #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huydhn merged 2 commits into from
Apr 22, 2026
Merged

Run integration tests after prod deployment #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74c458
Skip compactor e2e tests on prod deploy
huydhn Apr 22, 2026
cecafd7
Skip smoke + compactor on prod deploy, run integration
huydhn Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/_osdc-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,21 @@ on:
required: false
type: boolean
default: true
run_smoke:
description: "Run smoke tests after deploy"
required: false
type: boolean
default: true
run_integration:
description: "Run integration tests after deploy (requires CANARY_GITHUB_TOKEN)"
required: false
type: boolean
default: true
run_compactor:
description: "Run compactor e2e tests after deploy"
required: false
type: boolean
default: true
skip_lint_test:
description: "Skip `just lint` and `just test` pre-flight checks (firefighting only)"
required: false
Expand Down Expand Up @@ -91,6 +101,7 @@ jobs:
smoke:
name: Smoke tests
needs: deploy
if: ${{ inputs.run_smoke }}
runs-on: ubuntu-latest
environment: ${{ inputs.environment }}
timeout-minutes: 30
Expand Down Expand Up @@ -125,6 +136,7 @@ jobs:
compactor:
name: Compactor e2e tests
needs: deploy
if: ${{ inputs.run_compactor }}
runs-on: ubuntu-latest
environment: ${{ inputs.environment }}
timeout-minutes: 30
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/osdc-deploy-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ jobs:
environment: osdc-production
taint_nodes: ${{ inputs.taint_nodes }}
skip_lint_test: ${{ inputs.skip_lint_test }}
# Integration tests target pytorch-canary via CANARY_GITHUB_TOKEN —
# they don't belong in a prod deploy. Always skip.
run_integration: false
run_smoke: false
run_compactor: false
secrets:
META_AWS_ACC_ID: ${{ secrets.META_AWS_ACC_ID }}
META_AWS_DEPLOY_ROLE: ${{ secrets.META_AWS_DEPLOY_PROD_ROLE }}
CANARY_GITHUB_TOKEN: ${{ secrets.CANARY_GITHUB_TOKEN }}
Loading