cmake: convert x86* variants to x86 and x86_64#286
Open
1480c1 wants to merge 1 commit intopytorch:mainfrom
Open
cmake: convert x86* variants to x86 and x86_64#2861480c1 wants to merge 1 commit intopytorch:mainfrom
1480c1 wants to merge 1 commit intopytorch:mainfrom
Conversation
Contributor
|
can you rebase? Also for some reason CI didn't run |
This should reduce the number of checks for other variants like AMD64, amd64, etc. Signed-off-by: Christopher Degawa <ccom@randomderp.com>
1480c1
force-pushed
the
cmake/canonicalizex86
branch
from
c9a331d to
789a7ec
Compare
fbarchard
reviewed
Jan 30, 2026
|
|
||
| IF(CPUINFO_SUPPORTED_PLATFORM) | ||
| IF(NOT CMAKE_SYSTEM_NAME STREQUAL "Emscripten" AND (CPUINFO_TARGET_PROCESSOR MATCHES "^(i[3-6]86|AMD64|x86(_64)?)$" OR IOS_ARCH MATCHES "^(i386|x86_64)$")) | ||
| IF(NOT CMAKE_SYSTEM_NAME STREQUAL "Emscripten" AND (CPUINFO_TARGET_PROCESSOR MATCHES "^x86(_64)?$" OR IOS_ARCH MATCHES "^(i386|x86_64)$")) |
Collaborator
There was a problem hiding this comment.
should i386 change for ios? seems like you could remove 32 bit x86 from ios simulator at this point?
fbarchard
approved these changes
Jan 30, 2026
Collaborator
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
This change makes sense and looks good to me.
x86 and x86_64 are the common names used
would be good to rebase and land it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce the number of checks for other variants like AMD64, amd64, etc.