Apply RESTRICT_STATIC MSVC workaround to arm/cache.c as well#289
Apply RESTRICT_STATIC MSVC workaround to arm/cache.c as well#289MarijnS95 wants to merge 1 commit intopytorch:mainfrom
RESTRICT_STATIC MSVC workaround to arm/cache.c as well#289Conversation
In pytorch#283 a workaround was introduced to remove the `restrict static` attributes on MSVC where it is not supported. This was only defined and used in `arm/api.h` however and not in `arm/cache.c`, leading to this file to fail compilation because it is included in `ARM_SRCS` for the `windows_arm64` target in `BUILD.bazel`. Fix that by replacing `restrict static` with `RESTRICT_STATIC` which will be defined by the `arm/api.h` header that is already included in `arm/cache.c`.
|
Hi @MarijnS95! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Update the submodule to incorporate the fixes from pytorch/cpuinfo#283 and a (not-yet-merged) followup compilation fix from pytorch/cpuinfo#289.
|
Please sign the CLA to merge the PR |
3 participants
In #283 a workaround was introduced to remove the
restrict staticattributes on MSVC where it is not supported.This was only defined and used in
arm/api.hhowever and not inarm/cache.c, leading to this file to fail compilation because it is included inARM_SRCSfor thewindows_arm64target inBUILD.bazel.Fix that by replacing
restrict staticwithRESTRICT_STATICwhich will be defined by thearm/api.hheader that is already included inarm/cache.c.