Refactor CPU ISA to be compiled instead of static#302
Refactor CPU ISA to be compiled instead of static#302BoyeGuillaume wants to merge 1 commit intopytorch:mainfrom
Conversation
This commit introduces a new source file `isa.c` that implements functions to check for various CPU features across x86, ARM, and RISC-V architectures. This facilitate the definition of FFI for interfacing with other languages such as Rust or Python in automated tooling.
|
Hi @BoyeGuillaume! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
The term FFI seems to mean you want to call cpuinfo from other languages, such as Cobol :-) I have no strong opinion on the content of this PR, aside from it looks like you did it correctly. |
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
There are 3 build files that need updates:
CMakeLists.txt
BUILD.bazel
jni/Android.mk
3 participants
This commit introduces a new source file
isa.cthat implements functions to check for various CPU features across x86, ARM, and RISC-V architectures. This facilitate the definition of FFI for interfacing with other languages such as Rust or Python in automated tooling.