[DataPipe] file decoder #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2022 12:29
facebook-github-bot
added
the
CLA Signed
msaroufim
reviewed
May 17, 2022
| return pickle.load(stream) | ||
|
|
||
|
|
||
| default_decoders = [ |
There was a problem hiding this comment.
@wenleix I like this feels like a natural place to add more exotic decoders like NVJpeg
There was a problem hiding this comment.
Image decoders depend on third party libraries. Furthermore, the output people desire from image decoders (PIL, tensor, ndarray, ...) depends on what data augmentation pipeline they use. That's why image decoders aren't present by default. Users can select the image decoder they want to use with just a single line.
Of course, if you prefer, we could pick a default for image decoding.
There are a few more default decoders one might want to add (e.g., JSON).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a filter that simplifies file decoding for archive files. It allows glob patterns to be matched against a stream of (filename, stream) pairs and invokes the corresponding decoder on the stream.