Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python failing tests #1299

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix python failing tests #1299

merged 1 commit into from
Nov 5, 2024

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Nov 5, 2024

Summary:
Python tests are failing because of module/version incompatibilities. This change is pulling out the failing tests issue from
#1297 into a separate commit so that the 2 changes can be committed independently.

  1. Pick specific version of torchvision to fix dependency errors
  2. Pin numpy to be below version 2.
  3. Update Python version in python tests.

Test Plan:
Tested locally.

Summary:
1. Pick specific version of torchvision to fix dependency errors
2. Pin numpy to be below version 2.
3. Update Python version in python tests.

Test Plan:
Tested locally.
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 390a9b7
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/672a5a159798ed00085a6e37

Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@c-p-i-o c-p-i-o merged commit 47d0c2e into main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants